Repository navigation
Remove implementation of traits that can confuse users because of lack well-defining meaning - #1007
Conversation
…k well-defining meaning
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
- Coverage 57.31% 55.28% -2.04%
==========================================
Files 46 51 +5
Lines 18197 18721 +524
==========================================
- Hits 10429 10349 -80
- Misses 7768 8372 +604
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@dralley, It seems that this PR was not included in v0.42.0, because you pushed release before it was merged 😕 |
|
I did merge it first. Looking at the chain of events, it looks like I just forgot to (which in hindsight is an error-prone workflow, should have just switched back to master branch and Sorry. Would you like to see a re-release as 0.42.1, or just move it to the Unreleased section? |
|
Removing trait implementation would be a breaking change. I suggest to following course of actions:
Just did the first two points. |
As discussed in #1005